Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ESM in danger-js code #24

Open
TomStrepsil opened this issue Feb 11, 2025 · 0 comments
Open

Allow ESM in danger-js code #24

TomStrepsil opened this issue Feb 11, 2025 · 0 comments

Comments

@TomStrepsil
Copy link
Contributor

TomStrepsil commented Feb 11, 2025

When babel-preset-asos was introduced (to allow the repository to be open-sourced, in version 0.1.0 of the root repository), an issue with danger-js was discovered.

The babel-preset-asos code could not itself be processed by babel, otherwise a circular reference / call stack max-out would occur. This meant the preset had to be ignored, via the babel config.

Unfortunately, danger-js did not handle ignored files well when it transpiled its source or any supplied plugins, meaning a concession was made to convert all of this to commonJs format code, that would run natively in Node.

Having fixed the issue with danger-js, this repo can be put back to its original form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant